lkml.org 
[lkml]   [2021]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/17] media: atomisp: pci: add missing media_device_cleanup() in atomisp_unregister_entities()
    Date
    After the commit 9832e155f1ed ("[media] media-device: split media
    initialization and registration"), calling media_device_cleanup()
    is needed it seems. However, currently it is missing for the module
    unload path.

    Note that for the probe failure path, it is already added in
    atomisp_register_entities().

    This patch adds the missing call of media_device_cleanup() in
    atomisp_unregister_entities().

    Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
    Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
    ---
    drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
    index 1e324f1f656e..0511c454e769 100644
    --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
    +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
    @@ -1182,6 +1182,7 @@ static void atomisp_unregister_entities(struct atomisp_device *isp)

    v4l2_device_unregister(&isp->v4l2_dev);
    media_device_unregister(&isp->media_dev);
    + media_device_cleanup(&isp->media_dev);
    }

    static int atomisp_register_entities(struct atomisp_device *isp)
    --
    2.33.1
    \
     
     \ /
      Last update: 2021-10-17 18:21    [W:3.277 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site