Messages in this thread | | | Date | Sat, 16 Oct 2021 19:53:35 +0200 | Subject | Re: [PATCH] mm: allow huge kvmalloc() calls if they're accounted to memcg | From | Paolo Bonzini <> |
| |
On 16/10/21 17:39, Linus Torvalds wrote: > The big allocation warnings are not about whether we have the memory > or not, or about whether it's accounted or not. > It's about bugs and overflows. Which we've had.
Yes, I understand that...
> At least GFP_NOWARN would be somewhat sensible - although still wrong.
... and it also seemed wrong to overload GFP_NOWARN.
> It should really be about "I've been careful with growing my > allocations", not about whether accounting or similar should be > disabled. If the allocations really are expected to be that big, and > it's actually valid, just do vmalloc(), which doesn't warn. Sounds good, and you'll get a pull request for that tomorrow. Then I'll send via Andrew a patch to add __vcalloc, so that the accounting is restored.
Paolo
| |