lkml.org 
[lkml]   [2021]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] staging: r8188eu: use completions and clean rtw_cmd_thread()
On Sat, Oct 16, 2021 at 11:10:39AM +0200, Fabio M. De Francesco wrote:
> This series replaces two semaphores with three completion variables
> in rtw_cmd_thread(). Completions variables are better suited for the
> purposes that are explained in detail in the commit messages of patches
> 1/3 and 2/3. Furthermore, patch 3/3 removes a redundant 'if' statement
> from that same rtw_cmd_thread().
>
> Tested with ASUSTek Computer, Inc. Realtek 8188EUS [USB-N10 Nano]
>
> Many thanks to Dan Carpenter <dan.carpenter@oracle.com> who helped with
> his review of the RFC Patch.
>
> Fabio M. De Francesco (3):
> staging: r8188eu: Use completions for signaling start and end of
> kthread
> staging: r8188eu: Use completions for signaling enqueueing of commands
> staging: r8188eu: Remove redundant 'if' statement
>
> drivers/staging/r8188eu/core/rtw_cmd.c | 19 +++++++------------
> drivers/staging/r8188eu/include/rtw_cmd.h | 5 +++--
> drivers/staging/r8188eu/os_dep/os_intfs.c | 8 +++++---
> 3 files changed, 15 insertions(+), 17 deletions(-)
>
> --
> 2.33.0
>

Dear Fabio,

Built and tested on my USB-N10 Nano, working well. In terms of how
you've split the patches out, I have no problem with it personally,
given that one semaphore was there for kthread start/stop and the other
for queuing. Looks good to me anyway based on what I know of completion
variables :-) I assume you've not made the waits killable or
interruptible in patch 1 due to the fact they are specifically related
to kthread start/stop? Anyhow:

For whole series:
Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil

\
 
 \ /
  Last update: 2021-10-16 17:28    [W:0.097 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site