lkml.org 
[lkml]   [2021]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RESEND] clk-si5341: replace snprintf in show functions with sysfs_emit
    Date
    coccicheck complains about the use of snprintf() in sysfs show functions.

    Fix the following coccicheck warning:
    drivers/clk/clk-si5341.c:1471: WARNING: use scnprintf or sprintf.
    drivers/clk/clk-si5341.c:1486: WARNING: use scnprintf or sprintf.
    drivers/clk/clk-si5341.c:1501: WARNING: use scnprintf or sprintf.
    drivers/clk/clk-si5341.c:1516: WARNING: use scnprintf or sprintf.

    Use sysfs_emit instead of scnprintf or sprintf makes more sense.

    Signed-off-by: Qing Wang <wangqing@vivo.com>
    ---
    drivers/clk/clk-si5341.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
    index 57ae183..5d62ddb 100644
    --- a/drivers/clk/clk-si5341.c
    +++ b/drivers/clk/clk-si5341.c
    @@ -1468,7 +1468,7 @@ static ssize_t input_present_show(struct device *dev,
    if (res < 0)
    return res;
    res = !(status & SI5341_STATUS_LOSREF);
    - return snprintf(buf, PAGE_SIZE, "%d\n", res);
    + return sysfs_emit(buf, "%d\n", res);
    }
    static DEVICE_ATTR_RO(input_present);

    @@ -1483,7 +1483,7 @@ static ssize_t input_present_sticky_show(struct device *dev,
    if (res < 0)
    return res;
    res = !(status & SI5341_STATUS_LOSREF);
    - return snprintf(buf, PAGE_SIZE, "%d\n", res);
    + return sysfs_emit(buf, "%d\n", res);
    }
    static DEVICE_ATTR_RO(input_present_sticky);

    @@ -1498,7 +1498,7 @@ static ssize_t pll_locked_show(struct device *dev,
    if (res < 0)
    return res;
    res = !(status & SI5341_STATUS_LOL);
    - return snprintf(buf, PAGE_SIZE, "%d\n", res);
    + return sysfs_emit(buf, "%d\n", res);
    }
    static DEVICE_ATTR_RO(pll_locked);

    @@ -1513,7 +1513,7 @@ static ssize_t pll_locked_sticky_show(struct device *dev,
    if (res < 0)
    return res;
    res = !(status & SI5341_STATUS_LOL);
    - return snprintf(buf, PAGE_SIZE, "%d\n", res);
    + return sysfs_emit(buf, "%d\n", res);
    }
    static DEVICE_ATTR_RO(pll_locked_sticky);

    --
    2.7.4
    \
     
     \ /
      Last update: 2021-10-15 08:47    [W:3.309 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site