Messages in this thread | | | Subject | Re: [BUG] [5.15] Compilation error in arch/x86/kvm/mmu/spte.h with clang-14 | From | Christophe de Dinechin <> | Date | Fri, 15 Oct 2021 11:17:22 +0200 |
| |
> On 14 Oct 2021, at 22:50, Paolo Bonzini <pbonzini@redhat.com> wrote: > > On 14/10/21 21:06, Nick Desaulniers wrote: >>> If we want to fix this, my vote is for casting to an int and updating the comment >> At the least, I think bitwise operations should only be performed on >> unsigned types. > > This is not a bitwise operation, it's a non-short-circuiting boolean operation. I'll apply Jim's suggestion.
What about making it an inline function, which would require evaluation of arguments:
static __always_inline bool BITWISE_BOOLEAN_OR(bool a, bool b) { return a || b; // Safe here, because arguments have been evaluated }
Suggesting that because I'm always nervous about casts in macros hiding something that the type system would otherwise catch.
Christophe > > Paolo >
| |