Messages in this thread | | | Date | Fri, 15 Oct 2021 10:32:11 +0200 | From | Martin Kaiser <> | Subject | Re: [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c |
| |
Thus wrote Phillip Potter (phil@philpotter.co.uk):
> Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve > no purpose other than to print the name of the function they are in > (_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the > function, which is better accomplished by other means. Also remove > the jiffies assignment at the start of the function, as it is no > longer used.
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > --- > drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------ > 1 file changed, 6 deletions(-)
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c > index f6db5b05e6e7..abbd107ad3c1 100644 > --- a/drivers/staging/r8188eu/hal/usb_halinit.c > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c > @@ -1073,15 +1073,9 @@ static void _ReadRFType(struct adapter *Adapter)
> static int _ReadAdapterInfo8188EU(struct adapter *Adapter) > { > - u32 start = jiffies; > - > - MSG_88E("====> %s\n", __func__); > - > _ReadRFType(Adapter);/* rf_chip -> _InitRFType() */ > _ReadPROMContent(Adapter);
> - MSG_88E("<==== %s in %d ms\n", __func__, rtw_get_passing_time_ms(start)); > - > return _SUCCESS; > }
Makes sense to me. We should get rid of the prints that show only the function name.
Acked-by: Martin Kaiser <martin@kaiser.cx>
| |