Messages in this thread | | | Subject | Re: [PATCH] hwmon: replace snprintf in show functions with sysfs_emit | From | Guenter Roeck <> | Date | Fri, 15 Oct 2021 15:00:59 -0700 |
| |
On 10/14/21 11:48 PM, Qing Wang wrote: > show() must not use snprintf() when formatting the value to be > returned to user space. > > Fix the following coccicheck warning: > drivers/hwmon/smm665.c:378: WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > Signed-off-by: Qing Wang <wangqing@vivo.com>
Please refrain from such cleanup patches unless you also make functional changes to a driver.
Guenter
> --- > drivers/hwmon/smm665.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/smm665.c b/drivers/hwmon/smm665.c > index 62906d9..122031e 100644 > --- a/drivers/hwmon/smm665.c > +++ b/drivers/hwmon/smm665.c > @@ -375,7 +375,7 @@ static ssize_t smm665_show_##what(struct device *dev, \ > { \ > struct sensor_device_attribute *attr = to_sensor_dev_attr(da); \ > const int val = smm665_get_##what(dev, attr->index); \ > - return snprintf(buf, PAGE_SIZE, "%d\n", val); \ > + return sysfs_emit(buf, "%d\n", val); \ > } > > SMM665_SHOW(min); >
| |