lkml.org 
[lkml]   [2021]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/12] regulator: Introduce tps68470-regulator driver
    On Fri, Oct 15, 2021 at 08:50:13PM +0200, Hans de Goede wrote:

    > Are you happy with the platform_data for this driver as defined in
    > patch 4/12 ? :

    Some of the other review comments lead me to believe that you'd be
    sending out a new version at some point?

    > https://lore.kernel.org/platform-driver-x86/20211008162121.6628-1-hdegoede@redhat.com/T/#m745cc1191f531a57ae7998f5c8817ba9a46f0fed

    I am very confused about why it's in the driver without a DMI quirk
    and/or clear comments about why and saying that this is a terrible
    example to copy. I'd also expect to get compile test coverage for the
    driver.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-10-15 21:00    [W:3.867 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site