Messages in this thread | | | Subject | Re: [PATCH v1 04/10] asm-generic: Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR to define associated stubs | From | Christophe Leroy <> | Date | Thu, 14 Oct 2021 09:20:32 +0200 |
| |
Le 13/10/2021 à 09:00, Kees Cook a écrit : > On Mon, Oct 11, 2021 at 05:25:31PM +0200, Christophe Leroy wrote: >> Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR instead of 'dereference_function_descriptor' >> to know whether arch has function descriptors. >> >> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > > I'd mention the intentionally-empty #if/#else in the commit log, as I, > like Helge, mentally tripped over it in the review. :) > > Reviewed-by: Kees Cook <keescook@chromium.org> >
Ok, I did it in v2.
I also renamed it HAVE_FUNCTION_DESCRIPTORS because behind the fact that it has some functions to dereference function descriptor, the main fact is that they have and use function descriptors.
Christophe
| |