Messages in this thread | | | Date | Thu, 14 Oct 2021 21:08:45 +0200 | From | Borislav Petkov <> | Subject | Re: [regression] commit d298b03506d3 ("x86/fpu: Restore the masking out of reserved MXCSR bits") |
| |
On Thu, Oct 14, 2021 at 09:46:50PM +0300, Ville Syrjälä wrote: > I figured you can write a reasonably succinct commit message, instead > of having me ramble on incoherently. ATM I don't even know what mxcsr > is or why clobbering it would cause floating point exceptions with > sse specifically. > > But I can certainly ramble, if you prefer that.
Well, you can simply say that d298b03506d3 was supposed to mask out the reserved bits in the MXCSR register but the author mistakenly used the negation of the mask.
And if the commit message is not explaining stuff properly, I'll fix it up, no worries there.
But your call - I'm done for today and I'll do a patch tomorrow. That is, unless you haven't decided that you wish to write one in the meantime and you've sent it to me overnight.
:-)))
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |