lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v1 1/1] device property: Add missed header in fwnode.h
    On Wed, Oct 13, 2021 at 7:21 PM Saravana Kannan <saravanak@google.com> wrote:
    >
    > On Wed, Oct 13, 2021 at 7:37 AM Andy Shevchenko
    > <andriy.shevchenko@linux.intel.com> wrote:
    > >
    > > When adding some stuff to the header file we must not rely on
    > > implicit dependencies that are happen by luck or bugs in other
    > > headers. Hence fwnode.h needs to use bits.h directly.
    > >
    > > Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")
    > > Cc: Saravana Kannan <saravanak@google.com>
    > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    >
    > Acked-by: Saravana Kannan <saravanak@google.com>

    I'm going to pick this up, thanks!

    > > ---
    > > include/linux/fwnode.h | 1 +
    > > 1 file changed, 1 insertion(+)
    > >
    > > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
    > > index 9f4ad719bfe3..3a532ba66f6c 100644
    > > --- a/include/linux/fwnode.h
    > > +++ b/include/linux/fwnode.h
    > > @@ -11,6 +11,7 @@
    > >
    > > #include <linux/types.h>
    > > #include <linux/list.h>
    > > +#include <linux/bits.h>
    > > #include <linux/err.h>
    > >
    > > struct fwnode_operations;
    > > --
    > > 2.33.0
    > >

    \
     
     \ /
      Last update: 2021-10-13 19:32    [W:3.459 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site