lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched/fair: Use rq->lock when checking cfs_rq list presence
On Mon, Oct 11, 2021 at 08:12:08PM +0100, Odin Ugedal <odin@uged.al> wrote:
> To be 100% clear, this can only happen when a control group is
> throttled while it has load
> (cfs_rq_is_decayed(cfs_rq) is false); and then its unthrottling race
> with its deletion?
> Is that a correct understanding Michal?

Yes, that's my working hypothesis but Vincent found a loophole in the
proposed fix under this assumption.


> Do you agree that that will also solve the problem Michal,
> or am I missing something obvious here?

It's not easy for me to verify this with a reproducer and as suggested
by your discomfort, let's dismiss this idea for the time being.

Michal

\
 
 \ /
  Last update: 2021-10-13 16:40    [W:0.156 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site