Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH] ipmi: ipmb: add CONFIG_I2C dependency | Date | Wed, 13 Oct 2021 16:36:53 +0200 |
| |
From: Arnd Bergmann <arnd@arndb.de>
When CONFIG_I2C is a loadable module, the slave interface is not available to built-in drivers:
x86_64-linux-ld: drivers/char/ipmi/ipmi_ipmb.o: in function `ipmi_ipmb_remove': ipmi_ipmb.c:(.text+0x37): undefined reference to `i2c_slave_unregister' x86_64-linux-ld: drivers/char/ipmi/ipmi_ipmb.o: in function `ipmi_ipmb_thread': ipmi_ipmb.c:(.text+0x284): undefined reference to `i2c_transfer'
Add another dependency to the ipmb backend to avoid this.
Fixes: 63c4eb347164 ("ipmi:ipmb: Add initial support for IPMI over IPMB") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/char/ipmi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig index ace882ed3d55..b061e6b513ed 100644 --- a/drivers/char/ipmi/Kconfig +++ b/drivers/char/ipmi/Kconfig @@ -77,7 +77,7 @@ config IPMI_SSIF config IPMI_IPMB tristate 'IPMI IPMB interface' - depends on I2C_SLAVE + depends on I2C && I2C_SLAVE help Provides a driver for a system running right on the IPMB bus. It supports normal system interface messages to a BMC on the IPMB -- 2.29.2
| |