Messages in this thread | | | Date | Wed, 13 Oct 2021 09:15:47 +0300 | From | Dan Carpenter <> | Subject | Re: Use of '%#02x' is almost always wrong |
| |
On Sun, Oct 10, 2021 at 09:45:30AM -0700, Joe Perches wrote: > Perhaps too many developers do not know that using '%#<width>x' > in printf output _includes_ the 0x prefix in the output width. >
This is a good point. Presumably you're going to add it to checkpatch.pl?
I looked at '%#04x' and you would think those would all be printing char types but some are printing shorts. :/ It's harder to deal with that because 50% are correct from the tiny sample I looked at.
regards, dan carpenter
| |