Messages in this thread | | | Date | Wed, 13 Oct 2021 14:35:18 +0300 | From | Mike Rapoport <> | Subject | Re: [PATCH] memblock: exclude NOMAP regions from kmemleak |
| |
On Wed, Oct 13, 2021 at 08:45:40AM +0100, Catalin Marinas wrote: > On Wed, Oct 13, 2021 at 08:47:56AM +0300, Mike Rapoport wrote: > > From: Mike Rapoport <rppt@linux.ibm.com> > > > > Vladimir Zapolskiy reports: > > > > commit a7259df76702 ("memblock: make memblock_find_in_range method private") > > invokes a kernel panic while running kmemleak on OF platforms with nomaped > > regions: > > > > Unable to handle kernel paging request at virtual address fff000021e00000 > > [...] > > scan_block+0x64/0x170 > > scan_gray_list+0xe8/0x17c > > kmemleak_scan+0x270/0x514 > > kmemleak_write+0x34c/0x4ac > > > > Indeed, NOMAP regions don't have linear map entries so an attempt to scan > > these areas would fault. > > > > Prevent such faults by excluding NOMAP regions from kmemleak. > > > > Link: https://lore.kernel.org/all/8ade5174-b143-d621-8c8e-dc6a1898c6fb@linaro.org > > Fixes: a7259df76702 ("memblock: make memblock_find_in_range method private") > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > > Tested-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Thanks!
I'm going to take it via memblock tree if that's fine with everybody.
-- Sincerely yours, Mike.
| |