Messages in this thread | | | Date | Wed, 13 Oct 2021 12:58:56 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's bound driver |
| |
Hello,
On Wed, Oct 13, 2021 at 05:54:28AM -0500, Bjorn Helgaas wrote: > On Wed, Oct 13, 2021 at 10:51:31AM +0200, Uwe Kleine-König wrote: > > On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote: > > > diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c > > > index d997c9c3ebb5..7eb3706cf42d 100644 > > > --- a/drivers/misc/cxl/guest.c > > > +++ b/drivers/misc/cxl/guest.c > > > @@ -20,38 +20,38 @@ static void pci_error_handlers(struct cxl_afu *afu, > > > pci_channel_state_t state) > > > { > > > struct pci_dev *afu_dev; > > > + struct pci_driver *afu_drv; > > > + struct pci_error_handlers *err_handler; > > > > These two could be moved into the for loop (where afu_drv was with my > > patch already). This is also possible in a few other drivers. > > That's true, they could. I tried to follow the prevailing style in > the file. At least in cxl, I didn't see any other cases of > declarations being in the minimal scope like that.
I don't care much, do whatever you consider nice. I'm happy you liked the cleanup and that you took it.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |