lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net 1/2] NFC: digital: fix possible memory leak in digital_tg_listen_mdaa()
    From
    Date
    On 13/10/2021 09:50, Ziyang Xuan wrote:
    > 'params' is allocated in digital_tg_listen_mdaa(), but not free when
    > digital_send_cmd() failed, which will cause memory leak. Fix it by
    > freeing 'params' if digital_send_cmd() return failed.
    >
    > Fixes: 1c7a4c24fbfd ("NFC Digital: Add target NFC-DEP support")
    > Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
    > ---
    > net/nfc/digital_core.c | 9 +++++++--
    > 1 file changed, 7 insertions(+), 2 deletions(-)
    >

    Good catch. Leak is only theoretical as digital_send_cmd() will fail
    only on memory allocation failure but your fix makes code correct.


    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2021-10-13 11:35    [W:4.486 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site