lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [EXT] Re: [PATCH v10 03/13] media: amphion: add amphion vpu device driver
    Date
    > -----Original Message-----
    > From: Randy Dunlap [mailto:rdunlap@infradead.org]
    > Sent: Thursday, October 14, 2021 6:17 AM
    > To: Ming Qian <ming.qian@nxp.com>; mchehab@kernel.org;
    > shawnguo@kernel.org; robh+dt@kernel.org; s.hauer@pengutronix.de
    > Cc: hverkuil-cisco@xs4all.nl; kernel@pengutronix.de; festevam@gmail.com;
    > dl-linux-imx <linux-imx@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>;
    > linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
    > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org
    > Subject: [EXT] Re: [PATCH v10 03/13] media: amphion: add amphion vpu
    > device driver
    >
    > Caution: EXT Email
    >
    > On 10/13/21 1:27 AM, Ming Qian wrote:
    > > diff --git a/drivers/media/platform/Kconfig
    > > b/drivers/media/platform/Kconfig index d9f90084c2f6..2465a5f7a073
    > > 100644
    > > --- a/drivers/media/platform/Kconfig
    > > +++ b/drivers/media/platform/Kconfig
    > > @@ -200,6 +200,25 @@ config VIDEO_TI_CAL_MC
    > >
    > > endif # VIDEO_TI_CAL
    > >
    > > +config VIDEO_AMPHION_VPU
    > > + tristate "Amphion VPU(Video Processing Unit) Codec IP"
    > > + depends on ARCH_MXC
    > > + depends on MEDIA_SUPPORT
    > > + depends on VIDEO_DEV
    > > + depends on VIDEO_V4L2
    > > + select V4L2_MEM2MEM_DEV
    > > + select VIDEOBUF2_DMA_CONTIG
    > > + select VIDEOBUF2_VMALLOC
    > > + default y
    >
    > This should not be "default y" unless it is needed to boot up some
    > platform/machine. And even then it should depend on that platform/machine
    > if possible.

    I'll remove the " default y " and submit again

    >
    > And there are 2 other drivers in that same Kconfig file that have the same
    > problem.
    >
    > > + help
    > > + Amphion VPU Codec IP contains two parts: Windsor and Malone.
    > > + Windsor is encoder that supports H.264, and Malone is decoder
    > > + that supports H.264, HEVC, and other video formats.
    > > + This is a V4L2 driver for NXP MXC 8Q video accelerator hardware.
    > > + It accelerates encoding and decoding operations on
    > > + various NXP SoCs.
    > > + To compile this driver as a module choose m here.
    >
    >
    > --
    > ~Randy
    \
     
     \ /
      Last update: 2021-10-14 03:50    [W:3.068 / U:23.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site