Messages in this thread Patch in this message | | | From | Jiasheng Jiang <> | Subject | [PATCH] hv_netvsc: Add comment of netvsc_xdp_xmit() | Date | Thu, 14 Oct 2021 01:26:26 +0000 |
| |
Adding comment to avoid the misusing of netvsc_xdp_xmit(). Otherwise the value of skb->queue_mapping could be 0 and then the return value of skb_get_rx_queue() could be MAX_U16 cause by overflow.
Fixes: 351e158 ("hv_netvsc: Add XDP support") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/net/hyperv/netvsc_drv.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index f682a55..ac9529c 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -803,6 +803,7 @@ void netvsc_linkstatus_callback(struct net_device *net, schedule_delayed_work(&ndev_ctx->dwork, 0); } +/* This function should only be called after skb_record_rx_queue() */ static void netvsc_xdp_xmit(struct sk_buff *skb, struct net_device *ndev) { int rc; -- 2.7.4
| |