Messages in this thread | | | Date | Wed, 13 Oct 2021 16:22:11 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] net: encx24j600: check error in devm_regmap_init_encx24j600 |
| |
On Tue, 12 Oct 2021 20:59:01 +0800 Nanyong Sun wrote: > devm_regmap_init may return error which caused by like out of memory, > this will results in null pointer dereference later when reading > or writing register:
Applied, but...
> -void devm_regmap_init_encx24j600(struct device *dev, > +int devm_regmap_init_encx24j600(struct device *dev, > struct encx24j600_context *ctx)
> -void devm_regmap_init_encx24j600(struct device *dev, > +int devm_regmap_init_encx24j600(struct device *dev, > struct encx24j600_context *ctx);
.. please make sure you adjust the continuation lines. checkpatch points this out.
| |