Messages in this thread | | | Date | Wed, 13 Oct 2021 16:12:59 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] init: Make unknown command line param message clearer |
| |
On Wed, 13 Oct 2021 17:35:02 -0500 Andrew Halaney <ahalaney@redhat.com> wrote:
> The prior message is confusing users, which is the exact opposite of the > goal. If the message is being seen, one of the following situations is > happening: > > 1. the param is misspelled > 2. the param is not valid due to the kernel configuration > 3. the param is intended for init but isn't after the '--' > delineator on the command line > > To make that more clear to the user, explicitly mention "kernel command > line" and also note that the params are still passed to user space to > avoid causing any alarm over params intended for init. > > Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters") > Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Thanks.
BTW, I'm still sitting on your "init/main.c: silence some -Wunused-parameter warnings", awaiting a response to Rasmus's suggestion: https://lkml.kernel.org/r/f06b8308-645b-031b-f9c6-b92400a269aa@rasmusvillemoes.dk
| |