Messages in this thread | | | Subject | Re: [PATCH v10 03/13] media: amphion: add amphion vpu device driver | From | Randy Dunlap <> | Date | Wed, 13 Oct 2021 15:16:38 -0700 |
| |
On 10/13/21 1:27 AM, Ming Qian wrote: > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index d9f90084c2f6..2465a5f7a073 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -200,6 +200,25 @@ config VIDEO_TI_CAL_MC > > endif # VIDEO_TI_CAL > > +config VIDEO_AMPHION_VPU > + tristate "Amphion VPU(Video Processing Unit) Codec IP" > + depends on ARCH_MXC > + depends on MEDIA_SUPPORT > + depends on VIDEO_DEV > + depends on VIDEO_V4L2 > + select V4L2_MEM2MEM_DEV > + select VIDEOBUF2_DMA_CONTIG > + select VIDEOBUF2_VMALLOC > + default y
This should not be "default y" unless it is needed to boot up some platform/machine. And even then it should depend on that platform/machine if possible.
And there are 2 other drivers in that same Kconfig file that have the same problem.
> + help > + Amphion VPU Codec IP contains two parts: Windsor and Malone. > + Windsor is encoder that supports H.264, and Malone is decoder > + that supports H.264, HEVC, and other video formats. > + This is a V4L2 driver for NXP MXC 8Q video accelerator hardware. > + It accelerates encoding and decoding operations on > + various NXP SoCs. > + To compile this driver as a module choose m here.
-- ~Randy
| |