Messages in this thread | | | From | Sumit Garg <> | Date | Wed, 13 Oct 2021 12:38:33 +0530 | Subject | Re: [PATCH v6 2/6] dt-bindings: arm: optee: add interrupt property |
| |
On Wed, 6 Oct 2021 at 12:45, Jens Wiklander <jens.wiklander@linaro.org> wrote: > > Adds an optional interrupt property to the optee binding. > > Reviewed-by: Rob Herring <robh@kernel.org> > Acked-by: Marc Zyngier <maz@kernel.org> > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> > --- > .../devicetree/bindings/arm/firmware/linaro,optee-tz.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) >
Apart from minor nit below:
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > index c24047c1fdd5..40c9f1901e3f 100644 > --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > @@ -24,6 +24,12 @@ properties: > compatible: > const: linaro,optee-tz > > + interrupts: > + maxItems: 1 > + description: | > + This interrupt which is used to signal an event by the secure world > + software is expected to be edge-triggered. > + > method: > enum: [smc, hvc] > description: | > @@ -46,6 +52,7 @@ examples: > optee { > compatible = "linaro,optee-tz"; > method = "smc"; > + interrupts = <0 187 1>;
nit: It would be better to use macros here:
+ interrupts = <GIC_SPI 187 IRQ_TYPE_EDGE_RISING>;
-Sumit
> }; > }; > > -- > 2.31.1 >
| |