lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 2/6] dt-bindings: arm: optee: add interrupt property
On Wed, 6 Oct 2021 at 12:45, Jens Wiklander <jens.wiklander@linaro.org> wrote:
>
> Adds an optional interrupt property to the optee binding.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Acked-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> ---
> .../devicetree/bindings/arm/firmware/linaro,optee-tz.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>

Apart from minor nit below:

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
> index c24047c1fdd5..40c9f1901e3f 100644
> --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
> +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
> @@ -24,6 +24,12 @@ properties:
> compatible:
> const: linaro,optee-tz
>
> + interrupts:
> + maxItems: 1
> + description: |
> + This interrupt which is used to signal an event by the secure world
> + software is expected to be edge-triggered.
> +
> method:
> enum: [smc, hvc]
> description: |
> @@ -46,6 +52,7 @@ examples:
> optee {
> compatible = "linaro,optee-tz";
> method = "smc";
> + interrupts = <0 187 1>;

nit: It would be better to use macros here:

+ interrupts = <GIC_SPI 187 IRQ_TYPE_EDGE_RISING>;

-Sumit

> };
> };
>
> --
> 2.31.1
>

\
 
 \ /
  Last update: 2021-10-13 09:09    [W:0.099 / U:2.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site