Messages in this thread | | | Subject | Re: [PATCH] cpuidle: tegra: add ARCH_SUSPEND_POSSIBLE dependency | From | Dmitry Osipenko <> | Date | Wed, 13 Oct 2021 23:49:04 +0300 |
| |
13.10.2021 19:01, Arnd Bergmann пишет: > From: Arnd Bergmann <arnd@arndb.de> > > Some StrongARM processors don't support suspend, which leads > to a build failure with the tegra cpuidle driver: > > WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND > Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n] > Selected by [y]: > - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y] > > arch/arm/kernel/sleep.o: in function `__cpu_suspend': > (.text+0x68): undefined reference to `cpu_sa110_suspend_size' > > Add an explicit dependency to make randconfig builds avoid > this combination. > > Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/cpuidle/Kconfig.arm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm > index 2cc3c208a180..af97992eaa82 100644 > --- a/drivers/cpuidle/Kconfig.arm > +++ b/drivers/cpuidle/Kconfig.arm > @@ -100,6 +100,7 @@ config ARM_MVEBU_V7_CPUIDLE > config ARM_TEGRA_CPUIDLE > bool "CPU Idle Driver for NVIDIA Tegra SoCs" > depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU > + depends on ARCH_SUSPEND_POSSIBLE > select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP > select ARM_CPU_SUSPEND > help >
Arnd, thank you for the patch!
Apparently ARM_QCOM_SPM_CPUIDLE doesn't have that problem visible because it selects QCOM_SPM, which depends on ARCH_QCOM, and thus ARCH_QCOM should be auto-selected(?). I'm curious whether this needs to be corrected, otherwise (ARCH_QCOM || COMPILE_TEST) doesn't make much sense for that driver. And then it will need the same Kconfig fix as well.
I assume this problem wasn't caught by regular kernel build bots because they don't test randconfig, don't they?
| |