Messages in this thread | | | From | Logan Gunthorpe <> | Date | Wed, 13 Oct 2021 12:35:19 -0600 | Subject | Re: [PATCH] RDMA/core: Set sgtable nents when using ib_dma_virt_map_sg() |
| |
On 2021-10-13 12:33 p.m., Bart Van Assche wrote: > On 10/13/21 9:59 AM, Logan Gunthorpe wrote: >> ib_dma_map_sgtable_attrs() should be mapping the sgls and setting nents >> but the ib_uses_virt_dma() path falls back to ib_dma_virt_map_sg() >> which will not set the nents in the sgtable. >> >> Check the return value (per the map_sg calling convention) and set >> sgt->nents appropriately on success. >> >> Link: >> https://lore.kernel.org/all/996fa723-18ef-d35b-c565-c9cb9dc2d5e1@acm.org/T/#u >> >> Reported-by: Bart Van Assche <bvanassche@acm.org> >> Signed-off-by: Logan Gunthorpe <logang@deltatee.com> >> Tested-by: Bart Van Assche <bvanassche@acm.org> > > Does this patch need a "Fixes:" tag?
Right, yeah:
Fixes: 79fbd3e1241c ("RDMA: Use the sg_table directly and remove the opencoded version from umem")
Logan
| |