lkml.org 
[lkml]   [2021]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] gen_init_cpio: add static const qualifiers
On ti. 12. okt. 2021 kl. 11.55 +0000 Masahiro Yamada wrote:
> Add 'const' to constant arrays. I also added missing 'static'.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

> ---
>
> usr/gen_init_cpio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c
> index 03b21189d58b..bf5b98c6cf8d 100644
> --- a/usr/gen_init_cpio.c
> +++ b/usr/gen_init_cpio.c
> @@ -188,7 +188,7 @@ struct generic_type {
> mode_t mode;
> };
>
> -static struct generic_type generic_type_table[] = {
> +static const struct generic_type generic_type_table[] = {
> [GT_DIR] = {
> .type = "dir",
> .mode = S_IFDIR
> @@ -491,7 +491,7 @@ static void usage(const char *prog)
> prog);
> }
>
> -struct file_handler file_handler_table[] = {
> +static const struct file_handler file_handler_table[] = {
> {
> .type = "file",
> .handler = cpio_mkfile_line,
> --
> 2.30.2
>

--
epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
-- frykten for herren er opphav til kunnskap --

\
 
 \ /
  Last update: 2021-10-12 22:17    [W:0.074 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site