Messages in this thread | | | Subject | Re: [PATCH v2 2/2] mm: use pidfd_get_task() | From | David Hildenbrand <> | Date | Tue, 12 Oct 2021 16:13:31 +0200 |
| |
On 11.10.21 15:32, Christian Brauner wrote: > From: Christian Brauner <christian.brauner@ubuntu.com> > > Instead of duplicating the same code in two places use the newly added > pidfd_get_task() helper. This fixes an (unimportant for now) bug where > PIDTYPE_PID is used whereas PIDTYPE_TGID should have been used.
What would have been the effect of the BUG? Is it worth Fixes: or better even separating out the fix?
> > Link: https://lore.kernel.org/r/20211004125050.1153693-3-christian.brauner@ubuntu.com > Cc: Vlastimil Babka <vbabka@suse.cz> > Cc: Suren Baghdasaryan <surenb@google.com> > Cc: Matthew Bobrowski <repnop@google.com> > Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com> > Cc: David Hildenbrand <david@redhat.com> > Cc: Jan Kara <jack@suse.cz> > Cc: Minchan Kim <minchan@kernel.org> > Reviewed-by: Matthew Bobrowski <repnop@google.com> > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> > --- > /* v2 */ > unchanged
Acked-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |