Messages in this thread | | | Subject | Re: [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist | From | Hector Martin <> | Date | Tue, 12 Oct 2021 14:34:09 +0900 |
| |
On 12/10/2021 12.21, Viresh Kumar wrote: > I am not sure why you need this, since _set_required_opps() has this check: > > if (unlikely(!required_opp_tables[0]->is_genpd)) { > dev_err(dev, "required-opps don't belong to a genpd\n"); > return -ENOENT; > } >
The table *is* assigned to a genpd (the memory controller), it's just that that genpd isn't actually a parent of the CPU device. Without the patch you end up with:
[ 3.040060] cpu cpu4: Failed to set performance rate of cpu4: 0 (-19) [ 3.042881] cpu cpu4: Failed to set required opps: -19 [ 3.045508] cpufreq: __target_index: Failed to change cpu frequency: -19
-- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub
| |