lkml.org 
[lkml]   [2021]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist
From
Date
On 12/10/2021 12.21, Viresh Kumar wrote:
> I am not sure why you need this, since _set_required_opps() has this check:
>
> if (unlikely(!required_opp_tables[0]->is_genpd)) {
> dev_err(dev, "required-opps don't belong to a genpd\n");
> return -ENOENT;
> }
>

The table *is* assigned to a genpd (the memory controller), it's just
that that genpd isn't actually a parent of the CPU device. Without the
patch you end up with:

[ 3.040060] cpu cpu4: Failed to set performance rate of cpu4: 0 (-19)
[ 3.042881] cpu cpu4: Failed to set required opps: -19
[ 3.045508] cpufreq: __target_index: Failed to change cpu frequency: -19


--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub

\
 
 \ /
  Last update: 2021-10-12 07:35    [W:0.074 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site