| Subject | Re: [PATCH 4/8] rtc: max77686: remove useless variable | From | Krzysztof Kozlowski <> | Date | Tue, 12 Oct 2021 10:01:22 +0200 |
| |
On 11/10/2021 17:56, Luca Ceresoli wrote: > rtc_24hr_mode is set to 1 in max77686_rtc_probe()->max77686_rtc_init_reg() > before being read and is never set back to 0 again. As such, it is de facto > a constant. > > Remove the variable and the unreachable code. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > drivers/rtc/rtc-max77686.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) >
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards, Krzysztof
|