lkml.org 
[lkml]   [2021]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/8] rtc: max77686: remove useless variable
From
Date
On 11/10/2021 17:56, Luca Ceresoli wrote:
> rtc_24hr_mode is set to 1 in max77686_rtc_probe()->max77686_rtc_init_reg()
> before being read and is never set back to 0 again. As such, it is de facto
> a constant.
>
> Remove the variable and the unreachable code.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> drivers/rtc/rtc-max77686.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-10-12 10:05    [W:0.267 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site