lkml.org 
[lkml]   [2021]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 097/151] perf jevents: Free the sys_event_tables list after processing entries
    Date
    From: Like Xu <likexu@tencent.com>

    [ Upstream commit b94729919db2c6737501c36ea6526a36d5d63fa2 ]

    The compiler reports that free_sys_event_tables() is dead code.

    But according to the semantics, the "LIST_HEAD(sys_event_tables)" should
    also be released, just like we do with 'arch_std_events' in main().

    Fixes: e9d32c1bf0cd7a98 ("perf vendor events: Add support for arch standard events")
    Signed-off-by: Like Xu <likexu@tencent.com>
    Reviewed-by: John Garry <john.garry@huawei.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20210928102938.69681-1-likexu@tencent.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/perf/pmu-events/jevents.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
    index 9604446f8360..8b536117e154 100644
    --- a/tools/perf/pmu-events/jevents.c
    +++ b/tools/perf/pmu-events/jevents.c
    @@ -1284,6 +1284,7 @@ int main(int argc, char *argv[])
    }

    free_arch_std_events();
    + free_sys_event_tables();
    free(mapfile);
    return 0;

    @@ -1305,6 +1306,7 @@ err_close_eventsfp:
    create_empty_mapping(output_file);
    err_out:
    free_arch_std_events();
    + free_sys_event_tables();
    free(mapfile);
    return ret;
    }
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-10-11 16:09    [W:4.121 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site