lkml.org 
[lkml]   [2021]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 68/83] i2c: acpi: fix resource leak in reconfiguration device addition
    Date
    From: Jamie Iles <quic_jiles@quicinc.com>

    [ Upstream commit 6558b646ce1c2a872fe1c2c7cb116f05a2c1950f ]

    acpi_i2c_find_adapter_by_handle() calls bus_find_device() which takes a
    reference on the adapter which is never released which will result in a
    reference count leak and render the adapter unremovable. Make sure to
    put the adapter after creating the client in the same manner that we do
    for OF.

    Fixes: 525e6fabeae2 ("i2c / ACPI: add support for ACPI reconfigure notifications")
    Signed-off-by: Jamie Iles <quic_jiles@quicinc.com>
    Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
    [wsa: fixed title]
    Signed-off-by: Wolfram Sang <wsa@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/i2c/i2c-core-acpi.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
    index 37c510d9347a..4b136d871074 100644
    --- a/drivers/i2c/i2c-core-acpi.c
    +++ b/drivers/i2c/i2c-core-acpi.c
    @@ -426,6 +426,7 @@ static int i2c_acpi_notify(struct notifier_block *nb, unsigned long value,
    break;

    i2c_acpi_register_device(adapter, adev, &info);
    + put_device(&adapter->dev);
    break;
    case ACPI_RECONFIG_DEVICE_REMOVE:
    if (!acpi_device_enumerated(adev))
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-10-11 16:00    [W:4.101 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site