lkml.org 
[lkml]   [2021]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] s390: Use string_upper() instead of open coded variant
On Mon, Oct 11, 2021 at 08:21:15AM +0000, David Laight wrote:
> ...
> > > + * This snprintf() call does two things:
> > > + * - makes a NUL-terminated copy of the input string
> > > + * - pads it with spaces
> > > + */
> > > + snprintf(tmp, sizeof(tmp), "%s ", name);
> >
> > I can't say I like code where I have to count spaces in order to
> > verify if the code is actually correct.
>
> What it wrong with "%-8.8s" ?

There's nothing wrong with it, except lack of imagination on my side ;)
Andy, care to to send a separate patch just for extmem.c?

\
 
 \ /
  Last update: 2021-10-11 12:10    [W:0.069 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site