Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v1 1/1] s390: Use string_upper() instead of open coded variant | Date | Mon, 11 Oct 2021 08:21:15 +0000 |
| |
... > > + * This snprintf() call does two things: > > + * - makes a NUL-terminated copy of the input string > > + * - pads it with spaces > > + */ > > + snprintf(tmp, sizeof(tmp), "%s ", name); > > I can't say I like code where I have to count spaces in order to > verify if the code is actually correct.
What it wrong with "%-8.8s" ?
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |