Messages in this thread | | | From | John Stultz <> | Date | Mon, 11 Oct 2021 20:51:04 -0700 | Subject | Re: [RFC][PATCH] iommu: Kconfig: Fix missing config option for CONFIG_ARM_SMMU_QCOM |
| |
On Mon, Oct 11, 2021 at 8:37 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Mon 11 Oct 22:26 CDT 2021, John Stultz wrote: > > > In commit 424953cf3c665 ("qcom_scm: hide Kconfig symbol"), some > > logic was added to make the code depend on CONFIG_ARM_SMMU_QCOM, > > however no such option exist. > > > > This caused regressions on db845c (and I suspect other qcom > > platforms), but can be easily fixed up by adding a new option > > to re-enable the newly conditionalized code. > > > > I set it to default to ARCH_QCOM, so folks don't have to > > discover this new option to keep things booting, but if folks > > would rather, I'm ok to drop that line. > > > > I've not looked where the discussion went, but Dmitry posted this end of > last week: > > https://lore.kernel.org/linux-arm-msm/20211010023350.978638-1-dmitry.baryshkov@linaro.org/
Oh, my apologies for not seeing this! I did search my mail log earlier, but I must have missed it.
So yes, I validated earlier that reverting the problematic chunks works as well, and I see Arnd did already have a similar patch to what I sent out.
I'd probably lean towards Arnd's patch, as he has been uncovering the problematic Kconfig edge cases.
thanks -john
| |