Messages in this thread | | | Date | Mon, 11 Oct 2021 07:39:52 +0000 | From | Simon Ser <> | Subject | Re: linux-next: build failure after merge of the amdgpu tree |
| |
On Monday, October 11th, 2021 at 09:33, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, Oct 08, 2021 at 06:07:33PM +0000, Simon Ser wrote: > > > Would it be reasonable to re-export get_mm_exe_file? amdgpu uses it here: > > > > https://gitlab.freedesktop.org/agd5f/linux/-/commit/0d4da915c7098eca2aa6f559f42e33b5e9c7c5e8 > > Seriously? No, it obviously not. Unexporting it is important to catch > utter crap like in that commit which should have never made it into a > maintainer tree.
I don't understand. Can you elaborate why you think this commit is "utter crap"?
I'd also appreciate if you could be a bit less aggressive. There's nothing "obvious" about this from my point of view.
| |