Messages in this thread | | | Date | Mon, 11 Oct 2021 23:52:57 +0300 | From | Laurent Pinchart <> | Subject | Re: [PATCH v3 4/5] drm: mxsfb: Print failed bus format in hex |
| |
Hi Guido,
Thank you for the patch.
On Mon, Oct 11, 2021 at 03:41:26PM +0200, Guido Günther wrote: > media-bus-formats.h has them in hexadecimal as well so matching with > that file saves one conversion when debugging. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Reviewed-by: Robert Foss <robert.foss@linaro.org> > --- > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index af6c620adf6e..d6abd2077114 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -89,7 +89,7 @@ static void mxsfb_set_formats(struct mxsfb_drm_private *mxsfb, > ctrl |= CTRL_BUS_WIDTH_24; > break; > default: > - dev_err(drm->dev, "Unknown media bus format %d\n", bus_format); > + dev_err(drm->dev, "Unknown media bus format 0x%x\n", bus_format);
I may have gone for 0x%04x as current media bus formats all hold in 16 bits, but it's not big deal.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> break; > } >
-- Regards,
Laurent Pinchart
| |