Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 11 Oct 2021 21:37:13 +0200 | Subject | Re: [PATCH] habanalabs: select CRC32 |
| |
On Mon, Oct 11, 2021 at 6:29 PM Vegard Nossum <vegard.nossum@oracle.com> wrote: > On 10/11/21 5:33 PM, Arnd Bergmann wrote: > I'm working on a couple of new make targets, satconfig and > satrandconfig, which can generate .configs that respect a set of choices > specified in a .satconfig file (and, of course, the Kconfig files). > > In this case, I was just doing satrandconfig builds and noticed that the > crc32_le ones popped up quite often so I just added CONFIG_CRC32=n to my > .satconfig, which means that satrandconfig will generate only configs > that have CRC32=n.
Ah nice! I had gone through some of those last year, but it was a rather tedious manual process, and having some tool for it sound really useful.
> I also suspect that satrandconfig samples the configuration space MUCH > more uniformly than randconfig, in the sense that "make randconfig" will > tend to have CRC32 enabled just because there are so many drivers that > _do_ select it. (Think of it this way, every prompt for an option that > has "select CRC32" in it will be another 50% probability of actually > enabling the option.)
Yes, of course. I've seen other problems like this often happen with
CONFIG_I2C=m CONFIG_LEDS_CLASS=m CONFIG_IPV6=m CONFIG_CRYPTO=m CONFIG_PM_SLEEP=n
Not sure if you're already hitting those or if you need to add something to your setup to make those more easy to find.
> I just tried doing 'make randconfig' 100 times and the result was> > This project itself is about 11 years old, but I made a breakthrough > recently and I'm polishing the patches for submission now. I thought I > would try to fix the breakage that I could find first so it doesn't > appear as if the tool itself is broken... (that's not to say it doesn't > have any bugs, however!)
Sounds great.
Arnd
| |