lkml.org 
[lkml]   [2021]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] WIP: dt-bindings: arm: hwmon: gpio-fan: Convert txt bindings to yaml
On Sun, Oct 10, 2021 at 4:50 PM David Heidelberg <david@ixit.cz> wrote:
>
>
>
>
> On Sun, Oct 10 2021 at 14:31:56 -0500, Rob Herring <robh@kernel.org>
> wrote:
> > On Sat, 09 Oct 2021 12:43:09 +0200, David Heidelberg wrote:
> >> Convert fan devices connected to GPIOs to the YAML syntax.
> >>
> >> Signed-off-by: David Heidelberg <david@ixit.cz>
> >> ---
> >> .../devicetree/bindings/hwmon/gpio-fan.txt | 41 -----------
> >> .../devicetree/bindings/hwmon/gpio-fan.yaml | 69
> >> +++++++++++++++++++
> >> 2 files changed, 69 insertions(+), 41 deletions(-)
> >> delete mode 100644
> >> Documentation/devicetree/bindings/hwmon/gpio-fan.txt
> >> create mode 100644
> >> Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
> >>
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for
> > dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1538743
> >
> >
> > fan: 'gpio-fan,speed-map' is a required property
> > arch/arm/boot/dts/kirkwood-nas2big.dt.yaml
> > arch/arm/boot/dts/kirkwood-net2big.dt.yaml
> This sounds correct.
>
> >
> > gpio-fan: gpio-fan,speed-map: 'anyOf' conditional failed, one must be
> > fixed:
> > arch/arm/boot/dts/gemini-dlink-dir-685.dt.yaml
> > arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml
> >
> Look like two arrays instead one expected.
>
> > gpio_fan: gpio-fan,speed-map: 'anyOf' conditional failed, one must be
> > fixed:
> > arch/arm/boot/dts/am57xx-beagle-x15.dt.yaml
> > arch/arm/boot/dts/am57xx-beagle-x15-revb1.dt.yaml
> > arch/arm/boot/dts/am57xx-beagle-x15-revc.dt.yaml
> Look like two arrays instead one expected.
>
> >
> > gpio-fan: gpio-fan,speed-map: 'oneOf' conditional failed, one must be
> > fixed:
> > arch/arm/boot/dts/gemini-dlink-dir-685.dt.yaml
> > arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml
> >
> Look like three arrays instead one expected.
>
> > gpio_fan: gpio-fan,speed-map: 'oneOf' conditional failed, one must be
> > fixed:
> > arch/arm/boot/dts/am57xx-beagle-x15.dt.yaml
> > arch/arm/boot/dts/am57xx-beagle-x15-revb1.dt.yaml
> > arch/arm/boot/dts/am57xx-beagle-x15-revc.dt.yaml
> >
> Look like two arrays instead one expected.
>
> I can send patches to solve these warnings.

Certainly not required, but would be nice. I sent it more for whether
anything in the schema should change.

Rob

\
 
 \ /
  Last update: 2021-10-11 20:46    [W:0.052 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site