Messages in this thread | | | Subject | Re: [PATCH v3 05/11] clk: Introduce clk-tps68470 driver | From | Randy Dunlap <> | Date | Sun, 10 Oct 2021 12:22:21 -0700 |
| |
On 10/10/21 11:57 AM, Hans de Goede wrote: > The TPS68470 PMIC provides Clocks, GPIOs and Regulators. At present in > the kernel the Regulators and Clocks are controlled by an OpRegion > driver designed to work with power control methods defined in ACPI, but > some platforms lack those methods, meaning drivers need to be able to > consume the resources of these chips through the usual frameworks. > > This commit adds a driver for the clocks provided by the tps68470, > and is designed to bind to the platform_device registered by the > intel_skl_int3472 module. > > This is based on this out of tree driver written by Intel: > https://github.com/intel/linux-intel-lts/blob/4.14/base/drivers/clk/clk-tps68470.c > with various cleanups added. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > Changes in v2: > - Update the comment on why a subsys_initcall is used to register the drv > - Fix trailing whitespice on line 100 > --- > drivers/clk/Kconfig | 6 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-tps68470.c | 256 +++++++++++++++++++++++++++++++++++ > include/linux/mfd/tps68470.h | 11 ++ > 4 files changed, 274 insertions(+) > create mode 100644 drivers/clk/clk-tps68470.c > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index c5b3dc97396a..7dffecac83d1 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -169,6 +169,12 @@ config COMMON_CLK_CDCE706 > help > This driver supports TI CDCE706 programmable 3-PLL clock synthesizer. > > +config COMMON_CLK_TPS68470 > + tristate "Clock Driver for TI TPS68470 PMIC" > + depends on I2C && REGMAP_I2C && INTEL_SKL_INT3472 > + help > + This driver supports the clocks provided by TPS68470
End that sentence with a period (full stop): '.'.
Also it should be indented with one tab + 2 spaces.
-- ~Randy
| |