lkml.org 
[lkml]   [2021]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] memblock: Neaten logging
From
Date
On Fri, 2021-10-01 at 16:12 -0700, Mike Rapoport wrote:
> On Fri, Oct 01, 2021 at 01:34:10PM -0700, Joe Perches wrote:
> > On Fri, 2021-10-01 at 09:37 -0700, Mike Rapoport wrote:
> > > On Thu, Sep 30, 2021 at 06:27:15PM -0700, Joe Perches wrote:
> > > > On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote:
> > > > > Hi Joe,
> > > > >
> > > > > On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote:
> > > > > > Use more typical kernel logging styles.
> > > > > >
> > > > > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt
> > > > >
> > > > > I don't see it as an improvement. On the contrary, the output becomes
> > > > > somewhat tautological:
> > > >
> > > > And rather easier to grep as the prefix is constant.
> > >
> > > memblock_ is perfectly greppable
> >
> > Of course, but only when it's there, 2 instances out of 9.
>
> I didn't object to the patch as a whole. I just don't like the pr_fmt
> definition.

You should do what you like. I did what I like.

cheers, Joe


\
 
 \ /
  Last update: 2021-10-02 01:21    [W:0.036 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site