Messages in this thread | | | Subject | Re: [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants | From | "H. Nikolaus Schaller" <> | Date | Fri, 1 Oct 2021 11:59:14 +0200 |
| |
> Am 01.10.2021 um 09:54 schrieb Andreas Kemnade <andreas@kemnade.info>: > > On Sat, 9 Jan 2021 11:01:03 -0600 > Adam Ford <aford173@gmail.com> wrote: > >> Previously, the 1GHz variants were marked as a turbo, >> because that variant has reduced thermal operating range. >> >> Now that the thermal throttling is in place, it should be >> safe to remove the turbo-mode from the 1GHz variants, because >> the CPU will automatically slow if the thermal limit is reached. >> >> Signed-off-by: Adam Ford <aford173@gmail.com> >> --- >> V2: The orignal patch had the wrong file added. Add the omap36xx.dtsi >> > hmm, I somehow expected that there is a revert of this thing going > through. But now, the turbo-mode is still missing
tagging by turbo-mode means the OPP is *disabled* by default and needs to be enabled actively.
> and I understood the > revert is only in Nikolaus' trees.
It is just a revert for the gta04a5 because I think it is the only board which is affected (maybe it would need SmartReflex in operation to fine tune the OPPs compared to the generic table). Therefore I have a patch which adds turbo-mode to the gta04a5.dts
> The 1Ghz mode was working for some > time but does not anymore. Is it just me or do others also have the > same problems?
That would be interesting to know.
BR, NIkolaus
> > >> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi >> index 05fe5ed127b0..20844dbc002e 100644 >> --- a/arch/arm/boot/dts/omap36xx.dtsi >> +++ b/arch/arm/boot/dts/omap36xx.dtsi >> @@ -72,7 +72,6 @@ opp1g-1000000000 { >> <1375000 1375000 1375000>; >> /* only on am/dm37x with speed-binned bit set */ >> opp-supported-hw = <0xffffffff 2>; >> - turbo-mode; >> }; >> }; >> >
| |