Messages in this thread Patch in this message | | | Date | Fri, 1 Oct 2021 12:15:15 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH 2/7] media: ipu3-cio2: Set valid initial format |
| |
Hi Ricardo,
On Tue, Sep 28, 2021 at 09:10:28PM +0000, Ricardo Ribalda wrote: > The initial format did not have a valid size. > > Fixes v4l2-compliance: > > fail: v4l2-test-formats.cpp(723): Video Output Multiplanar: > TRY_FMT(G_FMT) != G_FMT > test VIDIOC_TRY_FMT: FAIL > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/staging/media/ipu3/ipu3-v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c > index 38a2407645096..fbb9eb2ba99e4 100644 > --- a/drivers/staging/media/ipu3/ipu3-v4l2.c > +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c > @@ -1136,7 +1136,7 @@ static int imgu_v4l2_node_setup(struct imgu_device *imgu, unsigned int pipe, > def_pix_fmt.height = def_bus_fmt.height; > def_pix_fmt.field = def_bus_fmt.field; > def_pix_fmt.num_planes = 1; > - def_pix_fmt.plane_fmt[0].bytesperline = def_pix_fmt.width * 2; > + def_pix_fmt.plane_fmt[0].bytesperline = 2496;
Please derive the value from the width, don't use a number here.
-- Regards,
Sakari Ailus
| |