lkml.org 
[lkml]   [2021]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/3] regulator: mt6358: Add OF match table
    Date
    From: Matthias Brugger <mbrugger@suse.com>

    The binding documentation mentions that a compatible is required for the
    MT6358 device node. But the driver does not provide a OF match table.
    This way auto-loading is broken as the MFD driver that registers the
    device has a .of_compatible set which makes the platform .uevent
    callback report a OF modalias, but that's not in the module.

    Fixes: f67ff1bd58f0 ("regulator: mt6358: Add support for MT6358 regulator")
    Signed-off-by: Matthias Brugger <mbrugger@suse.com>

    ---

    Changes in v2:
    - check for CONFIG_OF
    - add Fixes tag

    drivers/regulator/mt6358-regulator.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c
    index 13cb6ac9a892..a4ed19a54ec6 100644
    --- a/drivers/regulator/mt6358-regulator.c
    +++ b/drivers/regulator/mt6358-regulator.c
    @@ -534,9 +534,18 @@ static const struct platform_device_id mt6358_platform_ids[] = {
    };
    MODULE_DEVICE_TABLE(platform, mt6358_platform_ids);

    +#ifdef CONFIG_OF
    +static const struct of_device_id mt6358_of_match[] = {
    + { .compatible = "mediatek,mt6358-regulator", },
    + { /* sentinel */ },
    +};
    +MODULE_DEVICE_TABLE(of, mt6358_of_match);
    +#endif
    +
    static struct platform_driver mt6358_regulator_driver = {
    .driver = {
    .name = "mt6358-regulator",
    + .of_match_table = of_match_ptr(mt6358_of_match),
    },
    .probe = mt6358_regulator_probe,
    .id_table = mt6358_platform_ids,
    --
    2.29.2
    \
     
     \ /
      Last update: 2021-01-09 12:28    [W:2.348 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site