lkml.org 
[lkml]   [2021]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/9] drm/msm/dpu: Remove unused call in wait_for_commit_done
    Date
    The call to dpu_encoder_phys_cmd_prepare_for_kickoff is useless as
    it's unused because the serialize_wait4pp variable is never set to
    true by .. anything, literally: remove the call.
    While at it, also reduce indentation by inverting the check for
    dpu_encoder_phys_cmd_is_master.

    Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
    ---
    drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 11 +++--------
    1 file changed, 3 insertions(+), 8 deletions(-)

    diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
    index c5cf59b5bd41..2311e98480b9 100644
    --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
    +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
    @@ -687,20 +687,15 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
    static int dpu_encoder_phys_cmd_wait_for_commit_done(
    struct dpu_encoder_phys *phys_enc)
    {
    - int rc = 0;
    struct dpu_encoder_phys_cmd *cmd_enc;

    cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);

    /* only required for master controller */
    - if (dpu_encoder_phys_cmd_is_master(phys_enc))
    - rc = _dpu_encoder_phys_cmd_wait_for_ctl_start(phys_enc);
    -
    - /* required for both controllers */
    - if (!rc && cmd_enc->serialize_wait4pp)
    - dpu_encoder_phys_cmd_prepare_for_kickoff(phys_enc);
    + if (!dpu_encoder_phys_cmd_is_master(phys_enc))
    + return 0;

    - return rc;
    + return _dpu_encoder_phys_cmd_wait_for_ctl_start(phys_enc);
    }

    static int dpu_encoder_phys_cmd_wait_for_vblank(
    --
    2.29.2
    \
     
     \ /
      Last update: 2021-01-09 14:40    [W:4.571 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site