lkml.org 
[lkml]   [2021]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] proc_sysctl: fix oops caused by incorrect command parameters.
On Fri, 8 Jan 2021 21:10:25 +0100 Michal Hocko <mhocko@suse.com> wrote:

> > > Why would that matter? A missing value is clearly a error path and it
> > > should be reported.
> >
> > This test is in the correct place. I think it's just a question of the
> > return values.
>
> I was probably not clear. The test for val is at the right place. I
> would just expect -EINVAL and have the generic code to report.

It does seem a bit screwy that process_sysctl_arg() returns zero in all
situations (parse_args() is set up to handle an error return from it).
But this patch is consistent with all the other error handling in
process_sysctl_arg().

\
 
 \ /
  Last update: 2021-01-09 02:52    [W:0.074 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site