lkml.org 
[lkml]   [2021]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 05/40] drm/amd/amdgpu/vega20_ih: Add missing descriptions for 'ih' and fix spelling error
    On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/amd/amdgpu/vega20_ih.c:378: warning: Function parameter or member 'ih' not described in 'vega20_ih_get_wptr'
    > drivers/gpu/drm/amd/amdgpu/vega20_ih.c:421: warning: Function parameter or member 'ih' not described in 'vega20_ih_irq_rearm'
    > drivers/gpu/drm/amd/amdgpu/vega20_ih.c:447: warning: Function parameter or member 'ih' not described in 'vega20_ih_set_rptr'
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
    > Cc: Feifei Xu <Feifei.Xu@amd.com>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 5 ++++-
    > 1 file changed, 4 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/vega20_ih.c b/drivers/gpu/drm/amd/amdgpu/vega20_ih.c
    > index 42032ca380ccf..5a3c867d58811 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/vega20_ih.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/vega20_ih.c
    > @@ -88,7 +88,7 @@ static void vega20_ih_init_register_offset(struct amdgpu_device *adev)
    > * vega20_ih_toggle_ring_interrupts - toggle the interrupt ring buffer
    > *
    > * @adev: amdgpu_device pointer
    > - * @ih: amdgpu_ih_ring pointet
    > + * @ih: amdgpu_ih_ring pointer
    > * @enable: true - enable the interrupts, false - disable the interrupts
    > *
    > * Toggle the interrupt ring buffer (VEGA20)
    > @@ -367,6 +367,7 @@ static void vega20_ih_irq_disable(struct amdgpu_device *adev)
    > * vega20_ih_get_wptr - get the IH ring buffer wptr
    > *
    > * @adev: amdgpu_device pointer
    > + * @ih: amdgpu_ih_ring pointer
    > *
    > * Get the IH ring buffer wptr from either the register
    > * or the writeback memory buffer (VEGA20). Also check for
    > @@ -414,6 +415,7 @@ static u32 vega20_ih_get_wptr(struct amdgpu_device *adev,
    > * vega20_ih_irq_rearm - rearm IRQ if lost
    > *
    > * @adev: amdgpu_device pointer
    > + * @ih: amdgpu_ih_ring pointer
    > *
    > */
    > static void vega20_ih_irq_rearm(struct amdgpu_device *adev,
    > @@ -439,6 +441,7 @@ static void vega20_ih_irq_rearm(struct amdgpu_device *adev,
    > * vega20_ih_set_rptr - set the IH ring buffer rptr
    > *
    > * @adev: amdgpu_device pointer
    > + * @ih: amdgpu_ih_ring pointer
    > *
    > * Set the IH ring buffer rptr.
    > */
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2021-01-08 21:33    [W:3.270 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site