lkml.org 
[lkml]   [2021]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive
    Hi Sebatian,

    On Fri, Jan 08, 2021 at 12:24:41PM +0100, Sebastian Reichel wrote:
    > Standard DRM panel driver for DSI command mode panel used by omapfb2 is also
    > available now. Just like the other panels its module name clashes with the
    > module from drivers/video/fbdev/omap2/omapfb/displays, part of the deprecated
    > omapfb2 fbdev driver. As omapfb2 can only be compiled when the omapdrm driver
    > is disabled, and the DRM panel drivers are useless in that case, make the
    > omapfb2 panel depend on the standard DRM panels being disabled to fix
    > the name clash.
    >
    > Fixes: cf64148abcfd ("drm/panel: Move OMAP's DSI command mode panel driver")
    > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

    For a backport this looks good:
    Acked-by: Sam Ravnborg <sam@ravnborg.org>

    But why is it it we need omapfb at all when we have omapdrm?
    Can we sunset all or some parts of omap support in video/?
    If not, what is missing to do so.

    Sam

    > ---
    > Laurent introduced and fixed the same issue for the other panels and
    > this simply replicates the same solution for DSI command mode panel.
    > ---
    > drivers/video/fbdev/omap2/omapfb/displays/Kconfig | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/video/fbdev/omap2/omapfb/displays/Kconfig b/drivers/video/fbdev/omap2/omapfb/displays/Kconfig
    > index 744416dc530e..384d74a126dc 100644
    > --- a/drivers/video/fbdev/omap2/omapfb/displays/Kconfig
    > +++ b/drivers/video/fbdev/omap2/omapfb/displays/Kconfig
    > @@ -43,6 +43,7 @@ config FB_OMAP2_PANEL_DPI
    > config FB_OMAP2_PANEL_DSI_CM
    > tristate "Generic DSI Command Mode Panel"
    > depends on BACKLIGHT_CLASS_DEVICE
    > + depends on DRM_PANEL_DSI_CM = n
    > help
    > Driver for generic DSI command mode panels.
    >
    > --
    > 2.29.2

    \
     
     \ /
      Last update: 2021-01-08 21:00    [W:5.349 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site