Messages in this thread | | | Subject | Re: [PATCH] Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity() | From | John Garry <> | Date | Fri, 8 Jan 2021 15:43:56 +0000 |
| |
On 08/01/2021 15:43, Greg KH wrote: > On Mon, Dec 21, 2020 at 10:30:55PM +0800, John Garry wrote: >> The current check of nvec < minvec for nvec returned from >> platform_irq_count() will not detect a negative error code in nvec. >> >> This is because minvec is unsigned, and, as such, nvec is promoted to >> unsigned in that check, which will make it a huge number (if it contained >> -EPROBE_DEFER). >> >> In practice, an error should not occur in nvec for the only in-tree >> user, but add a check anyway. >> >> Fixes: e15f2fa959f2 ("driver core: platform: Add devm_platform_get_irqs_affinity()") >> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >> Signed-off-by: John Garry <john.garry@huawei.com> >> --- >> I hope that this can go through either irqchip or driver/core trees, thanks! > > I'll take it, thanks. >
Hi Greg,
I think that Marc already has taken it:
https://lore.kernel.org/lkml/X%2Fh9vy%2F1h0E1hyN0@kroah.com/T/#m95ef1736dbbd801cd85a4144c8f13c2afe33bc2c
I hope it doesn't cause hassle.
Thanks, John
| |