lkml.org 
[lkml]   [2021]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arm64: make atomic helpers __always_inline
    Hi Arnd,

    On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote:
    > From: Arnd Bergmann <arnd@arndb.de>
    >
    > With UBSAN enabled and building with clang, there are occasionally
    > warnings like
    >
    > WARNING: modpost: vmlinux.o(.text+0xc533ec): Section mismatch in reference from the function arch_atomic64_or() to the variable .init.data:numa_nodes_parsed
    > The function arch_atomic64_or() references
    > the variable __initdata numa_nodes_parsed.
    > This is often because arch_atomic64_or lacks a __initdata
    > annotation or the annotation of numa_nodes_parsed is wrong.
    >
    > for functions that end up not being inlined as intended but operating
    > on __initdata variables. Mark these as __always_inline, along with
    > the corresponding asm-generic wrappers.

    Hmm, I don't fully grok this. Why does it matter if a non '__init' function
    is called with a pointer to some '__initdata'? Or is the reference coming
    from somewhere else? (where?).

    Will

    \
     
     \ /
      Last update: 2021-01-08 10:35    [W:2.879 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site