lkml.org 
[lkml]   [2021]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH][next] powercap/drivers/dtpm: Fix size of object being allocated
    On Mon, Jan 4, 2021 at 3:24 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
    >
    > On 04/01/2021 13:10, Colin King wrote:
    > > From: Colin Ian King <colin.king@canonical.com>
    > >
    > > The kzalloc allocation for dtpm_cpu is currently allocating the size
    > > of the pointer and not the size of the structure. Fix this by using
    > > the correct sizeof argument.
    > >
    > > Addresses-Coverity: ("Wrong sizeof argument")
    > > Fixes: 0e8f68d7f048 ("powercap/drivers/dtpm: Add CPU energy model based support")
    > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
    >
    > Good catch, thanks for fixing this
    >
    > Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

    Applied as 5.12 material, thanks!

    > > ---
    > > drivers/powercap/dtpm_cpu.c | 2 +-
    > > 1 file changed, 1 insertion(+), 1 deletion(-)
    > >
    > > diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
    > > index 6933c783c6b4..51c366938acd 100644
    > > --- a/drivers/powercap/dtpm_cpu.c
    > > +++ b/drivers/powercap/dtpm_cpu.c
    > > @@ -200,7 +200,7 @@ static int cpuhp_dtpm_cpu_online(unsigned int cpu)
    > > if (!dtpm)
    > > return -EINVAL;
    > >
    > > - dtpm_cpu = kzalloc(sizeof(dtpm_cpu), GFP_KERNEL);
    > > + dtpm_cpu = kzalloc(sizeof(*dtpm_cpu), GFP_KERNEL);
    > > if (!dtpm_cpu)
    > > goto out_kfree_dtpm;
    > >
    > >
    >
    >
    > --
    > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
    >
    > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
    > <http://twitter.com/#!/linaroorg> Twitter |
    > <http://www.linaro.org/linaro-blog/> Blog

    \
     
     \ /
      Last update: 2021-01-07 18:23    [W:3.180 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site